Revert "Add option for site variable in mkMessage's generated messages"
#297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ges" This reverts commit bec6151. This is a misfeature added to allow messages to depend on site data, but negates the ability of the messages feature to do I18n. For example, if you had a subsite and two instances of that subsite, you may want different names for whatever the parent site is. This feature was intended to allow you to sub in the name of the parent site. However, the subbed in word would not be correctly internationalised, and thus this breaks a fundamental feature of messages. The correct way to do the above is to create multiple messages sets with different parent site names, and their own sets of language files.
jezen
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit bec6151.
This is a misfeature added to allow messages to depend on site data, but negates the ability of the messages feature to do I18n. For example, if you had a subsite and two instances of that subsite, you may want different names for whatever the parent site is. This feature was intended to allow you to sub in the name of the parent site. However, the subbed in word would not be correctly internationalised, and thus this breaks a fundamental feature of messages.
The correct way to do the above is to create multiple messages sets with different parent site names, and their own sets of language files.
@jezen