Add option for site variable in mkMessage's generated messages #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
The `renderMessage` function takes in the site as its first variable, but for most cases does nothing with it except pass it to recursive cases. This commit allows the user to choose and name this site parameter, meaning it can be used in the various messages that `mkMessage` generates. This can allow for a message to include content based on some site data, as long as that data is present from the site data purely. For example, this can be used to change what the name of some component is between different instances of the same subsite.
L0neGamer
changed the title
Contributor
Author
|
This is potentially an unwanted change for shakespearean internationalisation. The reason for that is the recommended way of doing what this sets out to do may be to create alternative sets of messages for each different input, or for the message data structure to store the values you are getting from the site data. |
Member
|
This is great. Thanks! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should reebase ontop of
https://github.com/yesodweb/shakespeare/pull/290/files