Conversation
yelsayd
left a comment
yelsayd
left a comment
There was a problem hiding this comment.
nice, thanks for sending this out. let's fix the comments and get it merged! :)
yelsayd
left a comment
yelsayd
left a comment
There was a problem hiding this comment.
nice work, still a few more comments until we get there however. :) let's push for it and get these fixed and merged. :)
|
@mohamedsaleh1984 Gentle ping on this, could you follow up with the comments so we can get this merged? Let me know if you need some help with it. :) |
|
Hey Yasser, |
|
Understood, no worries. I'll proceed with other changes then you can rebase or merge when you're ready to continue. :) |
yelsayd
left a comment
yelsayd
left a comment
There was a problem hiding this comment.
we're very close now, just a few things to fix then I'll merge this. :)
There was a problem hiding this comment.
looks good to me! thanks for following up with this!
we'll need to rebase the changes and resolve conflicts before merging the change, copying the changes manually results in lots of conflicts.
let me help with this part, I'll clone your changes locally, resolve conflicts, and push them again, then we can merge the pull request.
|
I created #12 to mirror your changes here since you'll need to rebase in order to merge this pull request. We can choose to merge that one instead (#12), which has all your changes (plus a cleanup commit from myself), or if you want you can give me write access to your fork repo and I'll rebase the changes there. Let me know what you wanna do. :) |
[skip ci]
2 participants
No description provided.