Conversation
Both make test-pg and QA_RUNBOOK.md now run migrations before pytest: - Makefile: docker compose run --rm migrate - QA_RUNBOOK (Docker): docker compose run --rm migrate - QA_RUNBOOK (Native): ./scripts/migrate.sh Without this, tests fail on fresh volumes with "Missing required tables".
docker-compose.test.yml: - Remove misleading "User: user@test.local" from header comment - Clarify that regular users are created via signup during tests docker-compose.yaml: - Change postgres:// to postgresql:// for consistency with other configs scripts/smoke_test.sh: - Add test_file_limits() to verify /v1/files/limits returns allowed_extensions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Strengthens test and QA workflows and standardizes DB configuration.
Makefileanddocker-compose.test.ymlworkflows (migrateservice)postgresql://indocker-compose.yaml(waspostgres://)docs/QA_RUNBOOK.mdto include running migrations (Docker and native) and minor cleanup flagsscripts/smoke_test.shwithGET /v1/files/limitsvalidation and includes it in the test sequenceWritten by Cursor Bugbot for commit 03d555e. This will update automatically on new commits. Configure here.