Conversation
- Fix chat payload: use {conversation_id, message: {content, mode}, stream}
instead of {conversation_id, content}
- Fix file upload endpoint: use /v1/files/upload (not /v1/files)
- Combine double curl calls into single call capturing body + status
- Remove 422 as acceptable success code (indicates test bug, not API issue)
- Fix bash arithmetic to avoid early exit with set -e
- Add || true to test calls so failures don't abort the suite
test_post_smoke.py:
- Fix chat payload to use correct schema: {conversation_id, message: {content, mode}, stream}
- Fix file upload assertion: check for fs_path (not file_id/id)
docker-compose.test.yml:
- Add bootstrap dependency to app service to ensure migrations run before app starts
Makefile test-pg: - Fix DATABASE_URL: liminallm:testpassword123 (was testuser:testpass) - Add USE_MEMORY_STORE=false to actually use PostgreSQL - Add REDIS_URL for redis-backed rate limits - Start redis container alongside postgres QA_RUNBOOK.md: - Fix Docker PostgreSQL test credentials to match compose - Add USE_MEMORY_STORE=false to both Docker and native PostgreSQL tests - Add REDIS_URL to Docker test section
Changed: - ADAPTER_OPENAI_API_KEY → OPENAI_ADAPTER_API_KEY - ADAPTER_OPENAI_BASE_URL → OPENAI_ADAPTER_BASE_URL These must match the env var names in config.py and .env.example.
runtime.py: - Remove unused `timedelta(seconds=window_seconds)` line in check_rate_limit() app.py: - Block direct access to /static/admin.html (returns 403) - Admin UI is only accessible via /admin route which enforces auth
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Tightens security and aligns QA/tests with current API and infra expectations.
/_static/admin.html; require/adminroute with auth inliminallm/app.py.scripts/smoke_test.shto use correct chat schema (message+mode,stream) and file upload endpointPOST /v1/files/upload; improve portability of counters and keep suite running on failures; enhance output with response bodies.tests/test_post_smoke.pyfor new upload response (fs_path) and chat schema in cross-user checks.redisalongsidepostgresfor PG tests; setUSE_MEMORY_STORE=false, updatedDATABASE_URL/REDIS_URL; addbootstrapdependency indocker-compose.test.yml.OPENAI_ADAPTER_*and correct examples/instructions inDEPLOYMENT.mdandQA_RUNBOOK.md(Redis, pgvector note, correct endpoints).Written by Cursor Bugbot for commit 39d57e7. This will update automatically on new commits. Configure here.