Do LspAttached autocmd in the buffer its actually called for#558
Open
64-bitman wants to merge 2 commits intoyegappan:mainfrom
Open
Do LspAttached autocmd in the buffer its actually called for#55864-bitman wants to merge 2 commits intoyegappan:mainfrom
64-bitman wants to merge 2 commits intoyegappan:mainfrom
Conversation
Opening a session file with multiple buffers open would only set bufnr for the buffer that is focused from the start.
win_execute doesn't require switching buffers, and LspAttached is called on buffers with windows (from what I can tell)
|
|
||
| if exists('#User#LspAttached') | ||
| doautocmd <nomodeline> User LspAttached | ||
| win_execute(bufwinnr(bnr), 'doautocmd <nomodeline> User LspAttached', silent) |
Contributor
There was a problem hiding this comment.
this seems incorrect, winnr maybe changed or not existed.
There was a problem hiding this comment.
what's more, if users have set some opt's like 'setl keywordprg', can it be set in the correct buffer?
Contributor
|
Thanks for the patch. I tried it, but it does not trigger the LspAttached (even if the window exists). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: opening a session file with multiple buffers open would only set bufnr for the buffer that is focused from the start. This prevents buffer local mappings and autocmds from working properly.