can add indicator Stochastics, Bollinger bands ? #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Yes it only happens when I quit jStock, but not when I use the File > Exit method. It only happens if I click on the actual java window and click Quit org.yccheok.jstock.gui.MainFrame or press command+Q the shortcut for quit. 2) It hangs means that it does not close when I tell it to close/quit and so it just stays open and nothing I click on in the application works, and so I have to force quit the application. 3) this behavior does not happen in 1.0.7h and I have the latest version of java for my specific Mac OS. Now, as i looked over the code you provided, I believe line 426 calls the image icon file on close, but cannot find it for Mac. I actually dont remember much of Java programming because I took that class many years ago, but line 2040 calls the Utils for Windows 7 and Windows 8, and not MacOS. Maybe that might be it? Not sure why it closes perfectly fine when I use the File > Exit but not when command+Q. Maybe compile it with Utils.isMac() as well? I wouldnt want you to waste time with this, but if its really easy to just add the line for mac it just helps users that are on mac computers and use command+Q to close programs easier. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
can add indicator Stochastics and Bollinger bands ?