Skip to content

Conversation

@Jc2k
Copy link
Member

@Jc2k Jc2k commented Sep 13, 2016

Resources marked as never-destroy are 'described', but it is fatal for a thing to be described and not there. The destroy policy should always be used and it should decide not to proceed. In addition we should describe an object where possible because other resources may depend on it.

Todo:

  • This change impacts a lot of tests which are tricky to fix nicely - they use fixtures and they get their (botocore stubbed) client from the describe plan. The correct fix is probably to have a service that returns a client for a resource, rather than having a separate client for describe/destroy/apply.

Resources marked as `never-destroy` are 'described', but it is fatal for a
thing to be described and not there.

The destroy policy should **always** be used and it should decide not to
proceed.

This change impacts a lot of tests which are tricky to fix nicely.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants