Prevent multiple enumeration in GenericArgsSatisfy#39
Open
MaxHayman wants to merge 1 commit intoyavuztor:masterfrom
Open
Prevent multiple enumeration in GenericArgsSatisfy#39MaxHayman wants to merge 1 commit intoyavuztor:masterfrom
MaxHayman wants to merge 1 commit intoyavuztor:masterfrom
Conversation
…using evaluation of parameters twice
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doing a property like this I was noticing that the line was being printed twice.
It was being evaluated in the isAllText call and allso in the CheckCriteria call in GenericArgsSatisfy.
Doing a ToList prevents this being evaluated multiple times by preventing multiple enumeration. I plan on having some not as fast logic behind some properties so evaluating these twice would be bad on performance.
This also leads to a ~15% performance increase in my testing.
Before
After
This also passes all the tests in the test project.