Replication of original PR #582: Add Reader and Writer protocols#4
Open
yashwanthatla wants to merge 1 commit intoreplicated-pr-582-beforefrom
Open
Replication of original PR #582: Add Reader and Writer protocols#4yashwanthatla wants to merge 1 commit intoreplicated-pr-582-beforefrom
yashwanthatla wants to merge 1 commit intoreplicated-pr-582-beforefrom
Conversation
| intersphinx_mapping = {'py': ('https://docs.python.org/3', None)} | ||
| # This should usually point to /3, unless there is a necessity to link to | ||
| # features in future versions of Python. | ||
| intersphinx_mapping = {'py': ('https://docs.python.org/3.14', None)} |
There was a problem hiding this comment.
🐛 Correctness Issue
Reference to non-existent Python version 3.14.
The intersphinx_mapping points to Python 3.14 documentation which doesn't exist yet, causing broken documentation links and build failures.
Current Code (Diff):
- intersphinx_mapping = {'py': ('https://docs.python.org/3.14', None)}
+ intersphinx_mapping = {'py': ('https://docs.python.org/3', None)}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| intersphinx_mapping = {'py': ('https://docs.python.org/3.14', None)} | |
| intersphinx_mapping = {'py': ('https://docs.python.org/3', None)} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Add Reader and Writer Protocol Classes to typing_extensions
Overview
This PR adds new
ReaderandWriterProtocol classes to the typing_extensions module, with a fallback mechanism that checks if the io module already has these classes.Change Types
Affected Modules
typing_extensions.pytyping_extensions.pytyping_extensions.pytest_typing_extensions.pyconf.pyNotes for Reviewers