Fixed the text on signup page#43
Conversation
|
@Samiksha-bajoria is attempting to deploy a commit to the yash vikram's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
share a screen recording please, in both pc and mobile view, so i can affirm |
|
can you submit these changes to "contribution" branch instead of the main branch? |
WalkthroughAdjusted JSX spacing in components/auth/auth-form.tsx CardFooter by inserting explicit {" "} around text near Terms of Service and Privacy Policy links to control line breaks. No logic, state, routing, or export changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Assessment against linked issues
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
components/auth/auth-form.tsx (1)
257-259: Spacing fix alone won’t guarantee single line; enforce no-wrap (desktop) and use Next.js Link.The {" "} additions add spaces but wrapping can still occur. To reliably meet the issue goal, wrap the text and apply responsive no-wrap, and switch to
next/link(avoidhref="#"jumps).Apply within these lines:
- By continuing, you agree to our {" "} - <a href="#" className="text-teal-600 hover:underline">Terms of Service</a> and {" "} - <a href="#" className="text-teal-600 hover:underline">Privacy Policy</a>. + <span className="whitespace-normal md:whitespace-nowrap"> + By continuing, you agree to our{' '} + <Link href="/terms" className="text-teal-600 hover:underline focus-visible:underline">Terms of Service</Link>{' '}and{' '} + <Link href="/privacy-policy" className="text-teal-600 hover:underline focus-visible:underline">Privacy Policy</Link>. + </span>Also add the import (outside this hunk):
+import Link from "next/link"Please confirm with screenshots/recording at mobile and desktop breakpoints, as the maintainer requested, and verify the intended routes for Terms/Privacy. Would you like me to add
md:whitespace-nowrapon the CardFooter instead if you prefer no extra span?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
components/auth/auth-form.tsx(1 hunks)
🔇 Additional comments (2)
components/auth/auth-form.tsx (2)
257-259: LGTM on the explicit JSX spaces.The inserted {" "} correctly fixes the visual gap between inline elements.
257-259: Process nudge: retarget branch per maintainer comment.Please change the PR base to the “contribution” branch and attach the requested screen recording for both PC and mobile views.
I have fixed the text on signup page earlier it was not visually appealing.
Update auth-form.tsx
Fixed #36
followed the code of conduct.
Summary by CodeRabbit