Fix flaky unit test TestBenchmarkStateGetQuantileSuccess #431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark200
force-pushed
the
fix-test-benchmark-state-get-quantile-success
branch
from
c8f87b7 to
8b52ed9
Compare
mark200
changed the title
mark200
force-pushed
the
fix-test-benchmark-state-get-quantile-success
branch
6 times, most recently
from
b13a7ab to
eb1f046
Compare
mark200
force-pushed
the
fix-test-benchmark-state-get-quantile-success
branch
from
f992fa2 to
1f43145
Compare
pulkit4tech
approved these changes
Aug 19, 2025
mark200
added a commit
to mark200/yab
that referenced
this pull request
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a flaky test which is failing on dev. The issue came when wrapping a float64 number as time.Duration (which converts to int64) value, which rounded the number down.
Fix is to first round the float64 value and then return it as a time.Duration value.