Контекст названий месяцев должен учитывать флаги и ширину поля #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix hash syntax to be 1.8-compatible
Conflicts: lib/russian.rb
fix rails_admin datetime
|
👍 |
|
Подскажите, пожалуйста, как дела с этим запросом? |
update i18n
Fix stack level too deep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Кажется, это уже несколько раз фиксили, и каждый раз неправильно.
Исправлено путем написания более злостных регулярок для %d и %e в соответствии с документацией strftime (http://ruby-doc.org/core-1.9.3/Time.html#method-i-strftime).
Чтобы уменьшить количество регулярочного мусора я не стал добавлять правила к %B, %b, %a и %A , так как использование флагов или ширины для них все равно не работает (как у товарища из #38), так как хак над strftime из I18n не учитывает флаги и ширину, и не будет работать, пока кто-нибудь это не починит там.