Support ActionBarDrawerToggle with DrawerArrowDrawable.#27
Open
artetrad wants to merge 1 commit intoyarolegovich:masterfrom
Open
Support ActionBarDrawerToggle with DrawerArrowDrawable.#27artetrad wants to merge 1 commit intoyarolegovich:masterfrom
artetrad wants to merge 1 commit intoyarolegovich:masterfrom
Conversation
Author
|
|
Author
|
@yarolegovich Hi! Would you be interested in reviewing the PR? Thanks in advance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Great library we are using it for a few months.
We wanted to be able to put a badge in the nav drawer's toggle using the support library's setDrawerArrowDrawable() on the ActionBarDrawerToggle class. This was something not possible since the ActionBarDrawerToggle is constructed internally in the SlidingRootNavLayout class.
So based on the following stack overflow post I added the functionality to the SlidingRootNav interface:
BadgeDrawerToggle getBadgeDrawerToggle();https://stackoverflow.com/questions/43881131/android-how-to-add-badge-counter-to-hamburger-navigation-menu-icon/43886113#43886113