#2228: Add cancelation of the geant4 simulation #2310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkwinta
requested review from
Copilot,
grzanka and
kmichalikk
and removed request for
Copilot
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements job cancellation functionality for the Geant4 local worker simulation service and updates the converter submodule dependency.
- Implements the previously unimplemented
cancelJobmethod to properly terminate and clean up simulation workers - Updates the converter submodule to a newer commit
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/services/Geant4LocalWorkerSimulationService.ts | Implements cancelJob method to mark workers for termination and remove them from tracking |
| src/libs/converter | Updates submodule to newer commit |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
grzanka
requested changes
Dec 19, 2025
Contributor
grzanka
left a comment
grzanka
left a comment
There was a problem hiding this comment.
Can you revert the converter update ? You set the converter to some old commit now.
Contributor
Author
Fixed. |
kmichalikk
requested changes
Dec 19, 2025
kmichalikk
approved these changes
Dec 19, 2025
grzanka
approved these changes
Dec 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces an implementation for the
cancelJobmethod in theGeant4LocalWorkerSimulationServiceclass, replacing the previous unimplemented error. It also updates thesrc/libs/convertersubmodule to a new commit.Key changes:
Feature Implementation:
cancelJobmethod inGeant4LocalWorkerSimulationService, allowing jobs to be safely terminated and cleaned up by marking the worker for termination and removing it from the internal tracking map.Dependency Update:
src/libs/convertersubmodule to a newer commit, which may bring in bug fixes or new features from the converter library.