Display estimated time remaining for simulation dataset download #2304
Conversation
|
@lkwinta take a look here, it may be relevant to your work now |
There was a problem hiding this comment.
Pull request overview
This PR adds an estimated time remaining feature for Geant4 dataset downloads, providing users with real-time feedback on download progress. The implementation uses an exponential smoothing algorithm to calculate download speed and estimate completion time, improving the user experience during potentially lengthy download operations.
- Implements download speed tracking with exponential smoothing for stable time estimates
- Adds a time formatting utility to display remaining time in a user-friendly format (seconds/minutes)
- Displays estimated time remaining in the UI next to downloading datasets
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| useTheme | ||
| } from '@mui/material'; | ||
| import { useState } from 'react'; | ||
| import { useEffect,useState } from 'react'; |
There was a problem hiding this comment.
Missing space after comma in the import statement. Should be import { useEffect, useState } from 'react'; to maintain consistency with the rest of the codebase where all imports have spaces after commas.
| import { useEffect,useState } from 'react'; | |
| import { useEffect, useState } from 'react'; |
| {status.status === DatasetDownloadStatus.PROCESSING && ( | ||
| <LinearProgress | ||
| variant='indeterminate' | ||
| value={status.total ? ((status.done ?? 0) / status.total) * 100 : 0} |
There was a problem hiding this comment.
The value prop should not be set on a LinearProgress component with variant='indeterminate'. When variant is 'indeterminate', the value prop is ignored and has no effect. This prop should only be used with 'determinate' or 'buffer' variants. Remove the value prop from this indeterminate LinearProgress component.
| value={status.total ? ((status.done ?? 0) / status.total) * 100 : 0} |
|
@martastn can you rebase or merge recent master here ? |
3 participants
No description provided.