otlpexport: add export request body metric #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I think we want > print(string.len("foóó"))
6
|
tanner-bruce
force-pushed
the
otlpexport/add-message-uncompressed-size
branch
from
b1762cc to
a3d4302
Compare
tanner-bruce
force-pushed
the
otlpexport/add-message-uncompressed-size
branch
from
a3d4302 to
1167d7b
Compare
yangxikun
requested changes
May 31, 2023
| @@ -1,5 +1,7 @@ | |||
| local http = require("resty.http") | |||
|
|
|||
| local exporter_message_size_uncompressed_metric = "otel.otlp_exporter.message_uncompressed_size" | |||
Owner
There was a problem hiding this comment.
Keep naming consistency: exporter_message_size_uncompressed_metric -> exporter_ message_uncompressed_size_metric
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@plantfansam
Resolves #70