Skip to content

Fix yaml annotations for zk config #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
teem0n merged 1 commit into from
Feb 13, 2026
Merged

Fix yaml annotations for zk config #234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/docker-tests-8.0.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:

env:
GO_VERSION: 1.25.6
DOCKER_API_VERSION: 1.43
DOCKER_API_VERSION: 1.45

jobs:
lint:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docker-tests-8.4.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:

env:
GO_VERSION: 1.25.6
DOCKER_API_VERSION: 1.43
DOCKER_API_VERSION: 1.45

jobs:
lint:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docker-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:

env:
GO_VERSION: 1.25.6
DOCKER_API_VERSION: 1.43
DOCKER_API_VERSION: 1.45

jobs:
lint:
Expand Down
4 changes: 2 additions & 2 deletions internal/dcs/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ import (
type ZookeeperConfig struct {
Hostname string `config:"hostname" yaml:"hostname"`
SessionTimeout time.Duration `config:"session_timeout" yaml:"session_timeout"`
Namespace string `config:"namespace,required"`
Hosts []string `config:"hosts,required"`
Namespace string `config:"namespace,required" yaml:"namespace"`
Hosts []string `config:"hosts,required" yaml:"hosts"`
BackoffInterval time.Duration `config:"backoff_interval" yaml:"backoff_interval"`
BackoffRandFactor float64 `config:"backoff_rand_factor" yaml:"backoff_rand_factor"`
BackoffMultiplier float64 `config:"backoff_multiplier" yaml:"backoff_multiplier"`
Expand Down
2 changes: 1 addition & 1 deletion tests/testutil/docker_composer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ func NewDockerComposer(project, config string) (*DockerComposer, error) {
project = filepath.Base(filepath.Dir(config))
}
dc := new(DockerComposer)
api, err := client.NewClientWithOpts(client.FromEnv, client.WithVersion("1.43"))
api, err := client.NewClientWithOpts(client.FromEnv, client.WithVersion("1.45"))
if err != nil {
return nil, fmt.Errorf("failed to connect to docker: %s", err)
}
Expand Down
Loading