Skip to content

Tech excdipoles normalization #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rreho wants to merge 8 commits into
base: bug-fixes
Choose a base branch
from
Open

Tech excdipoles normalization #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
469cf08
fix indentation in pwxml.py
rreho Dec 2, 2025
30823bb
Merge branch 'bug-fixes' of github.com:rreho/yambopy into bug-fixes
rreho Dec 2, 2025
d4f022c
merge
rreho Dec 10, 2025
ac3407d
Merge branch 'bug-fixes' of github.com:rreho/yambopy into bug-fixes
rreho Dec 28, 2025
48e5d79
Merge branch 'yambo-code:bug-fixes' into bug-fixes
rreho Jan 12, 2026
f9c4000
Merge branch 'yambo-code:bug-fixes' into bug-fixes
rreho Feb 2, 2026
af8d2ef
Merge branch 'yambo-code:bug-fixes' into bug-fixes
rreho Feb 17, 2026
b0d7632
normalization on exciton dipoles
rreho Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion yambopy/bse/excitondipoles.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ def exc_dipoles_pol(lattice_path,dipoles_path=None,bse_path=None,save_files=True
# Since we have dipoles for emission, we do not conjugate BS_wfc
# Then the results are directly the exciton dipoles for emission
dip_exc = np.einsum('nkcv,kicv->in',BS_wfc,dip_expanded,
optimize=True).astype(dtype=dipoles.dtype)
optimize=True).astype(dtype=dipoles.dtype)/np.sqrt(yexc.nkpoints)

if save_files:
if dip_file[-4:]!='.npy': dip_file = dip_file+'.npy'
Expand Down
1 change: 0 additions & 1 deletion yambopy/dbs/excitondb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,6 @@ def real_wf_to_cube(self, iexe, wfdb, fixed_postion=[0,0,0], supercell=[1,1,1],
excQpt = self.car_qpoint
# Convert the q-point to crystal coordinates
Qpt = wfdb.ydb.lat @ excQpt
print("Qpt: ",Qpt)
#
if fix_particle == 'h': name_file = 'electron'
else: name_file = 'hole'
Expand Down