Владимир Каткалов @katkalov #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eLoader for ImageTarget
…ng collage of image
| } | ||
|
|
||
| //Работает, но такое ощущение, что можно лучше) хочу критики | ||
| private void loadCollage(List<String> urls, Object o, Action1 setBitmap, |
Collaborator
There was a problem hiding this comment.
Action можно было не использовать, а как раз о чем я говорил - обернуть вью в таргет
тогда бы передавал таргет и хранил бы их, а не Object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
да начнется rx
ЗЫ: наверное
Задание 1
Задание 2
Запуск менее приоритетных задач на UI потоке, при наличии активной критической секции. е
Task.run() выполняется на UI- потоке
при скролле списка не сетить Bitmap'ы в ImageView*
ЗЫЫ: первое знакомство с rx считаю более-менее успешным) понравилось