-
Notifications
You must be signed in to change notification settings - Fork 20
@aleien, Манюхина #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
|
||
| @Override | ||
| public void loadCollage(List<String> urls, ImageTarget imageTarget, CollageStrategy collageStrategy) { | ||
| if (subs == null) subs = new CompositeSubscription(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Тебе не лень было два одинаковых метода писать?) Можно упаковать ImageView в ImageTarget
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
У меня в голове это висит, просто еще руки не дошли это сделать)
А так да, так и собиралась. Правда, не уверена была, что это нормально будет - упаковать в ImageTarget.
Там же так будет?
loadCollage(... ImageView imageview ...) {
loadCollage(...new ImageTarget(imageView)...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ага, типа того
Задание 1
Параллельная загрузка картинок реализована средствами rxjava, конкретно - через оператор zip
Можно улучшить - скачивать картинки в файл, и организовать кэш на диске.
Задание 2
Реализация запуска тасков через IdleHandler >:D