chore(dropdown): close on enter keypress set via aria autoclose attr#256
Closed
slantz wants to merge 1 commit intoyalabot:masterfrom
Closed
chore(dropdown): close on enter keypress set via aria autoclose attr#256slantz wants to merge 1 commit intoyalabot:masterfrom
slantz wants to merge 1 commit intoyalabot:masterfrom
Conversation
Member
|
According to the Foundation docs, the Closing this in favor of #230 which also implements autoclose and seems to be more robust. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native foundation dropdown Toggle allows to close it if it's opened by hitting "ENTER", when aria-autoclose="false" attribute is set.
This emulates this behaviour.