Skip to content

Custom classes to scrollbar and thumb elements#22

Open
bambeusz wants to merge 1 commit intoyads:masterfrom
bambeusz:master
Open

Custom classes to scrollbar and thumb elements#22
bambeusz wants to merge 1 commit intoyads:masterfrom
bambeusz:master

Conversation

@bambeusz
Copy link

the lib is great, but in my project i need funcionality I added. It's just about adding custom classes to thumb and scrollbar elements.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can these offsets not be applied using CSS and the custom classes?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see now you're using it in the calculation. Let's modify this to be an object. Like:

scrollbarOffset: {
   top: 0,
   bottom: 0,
   left: 0,
   right: 0
}

Also there's a naming inconsistency scrollbarClass vs scrollBarOffset...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's css problem with left offset. If applied it messes up position of scrollbar.
I'd apply only top, bottom and right offset, or would not apply any, and leave it to custom class

I did not analyze the code good enough to manipulate offset so easily. Should I just remove offsetting and mark an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants