Drop LFS support workaround #42
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be effective, the autoconf configuration header must be included before any other headers. Link: https://www.gnu.org/software/autoconf/manual/autoconf-2.63/html_node/Configuration-Headers.html
The workaround was necessary because config.h was included after the system headers, which rendered AC_SYS_LARGEFILE ineffective. However, the workaround no longer works with autoconf 2.72, as the cache variable ac_cv_sys_file_offset_bits is no longer implemented. Link: autotools-mirror/autoconf@cf09f48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workaround for Large File Support (LFS) was needed because the
config.hheader is included after the system headers. Also, the workaround is broken with autoconf 2.72 (see also #36).