please consider my commits #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vention This avoids warnings from compilers.
Old test was *p && isdigit(*p) && *p != '/' - this didn't detect and handle buffer underrun - *p should never be '\0' - if isdigit(*p) then *p cannot be '/' What should be done when the remainder of the name is empty? It would be good to explain why a suffix <digit>p is treated specially.
GCC thinks that "part" might be used (dereferenced) without initialization. It looks to me as if GCC's warning is correct. I initialize part to NULL to make sure such a use segfaults rather than do something random. What is the correct fix? GCC thinks that "disk" might be used without initialization. GCC's warning is wrong; initialize "disk" to silence GCC.
It could be that the correct fix would have been to conditionally set draw_this_time to 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have fixed a few bugs and made some code clearer.
I have NOT done sufficient testing.
I've tried to make each commit small and clear.
There are a few places where I added comments with "???".
These are at points where something should be done but I don't know what that is.