-
Notifications
You must be signed in to change notification settings - Fork 9
fix(ci): Correctly update and restore cache for lint:cpp-static-check's generated files . #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughGitHub Actions workflow configuration updated to replace static cache keys with hash-based keys that incorporate checksums of relevant files for the C++ static linting task, maintaining consistent key generation across cache restoration and saving steps. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Areas requiring attention:
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (2)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
#197 added caching of
lint:cpp-static-checkin GitHub workflow, which does not correctly insert new caches. The cache created are immutable, but we save cache using the same key, and the cache save failed. Thus, the GitHub workflow are using an obsolete cache that are create.This PR fixes this issue by appending the has of the cache content to the key. When restoring the cache, we use a prefix of that key, and actions/cache/restore will automatically select the newest entry.
Checklist
breaking change.
Validation performed
Summary by CodeRabbit