Skip to content

Conversation

@adamhutchings
Copy link
Collaborator

I cannot test the generation properly until after #123 is merged. But the rest of it works fine.

Copy link
Member

@JakeRoggenbuck JakeRoggenbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@adamhutchings
Copy link
Collaborator Author

I removed the checks manually and confirmed that it worked.

Copy link
Collaborator

@thondascully thondascully left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Peer reviewed 👍

note: If you end up adding more function types for some reason, a switch case is better served than if statements

@adamhutchings adamhutchings merged commit 17f2814 into y-flat:main Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants