add haven storage window object and extension detection#6
Open
thisisommore wants to merge 50 commits intoxxfoundation:mainfrom
Open
add haven storage window object and extension detection#6thisisommore wants to merge 50 commits intoxxfoundation:mainfrom
thisisommore wants to merge 50 commits intoxxfoundation:mainfrom
Conversation
… in window.localStoragePromise
…ository for speakeasy-web
… new repository for speakeasy-web" This reverts commit 36bff9c.
…Storage and remove unnecessary console logs in extSCallback.
…ne password decryption handling.
…r wasmbrowsertest and cleanenv, and set environment variables for Go WebAssembly build.
…est and cleanenv, and rename wasmbrowsertest binary for Go WebAssembly compatibility.
…env from .gitpod.yml, and rename wasmbrowsertest binary for improved Go WebAssembly compatibility.
…and improve configuration management. Removed unnecessary xxdk-wasm checkout location and added global git configuration handling in Dockerfile.
…a comment for cleanenv testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
1. Use extension storage
localStorage is still used
2. Use promise for some functions
Extension
Note
Window object is created on haven side, not on extension side.
This allows us to keep permission for extension limited to storage only.