Skip to content

Added missing Sabine Wren (Command)#690

Open
J1mBob wants to merge 2 commits intoxwingtmg:masterfrom
J1mBob:patch-127
Open

Added missing Sabine Wren (Command)#690
J1mBob wants to merge 2 commits intoxwingtmg:masterfrom
J1mBob:patch-127

Conversation

@J1mBob
Copy link
Copy Markdown
Contributor

@J1mBob J1mBob commented Jul 7, 2024

No description provided.

@J1mBob
Copy link
Copy Markdown
Contributor Author

J1mBob commented Jul 7, 2024

Not sure why the faction restriction of "Rebel Alliance" is failing.

@awsaba
Copy link
Copy Markdown

awsaba commented Jul 7, 2024

Not sure why the faction restriction of "Rebel Alliance" is failing.

@J1mBob That restriction is using the the XWS, it is working here: https://github.com/xwingtmg/xwing-data2/pull/688/files#diff-f5f86c9ce238cb0c1deb78b42d303f3c74adea729720b84bc9f08ffdd9f9e93cR636

@awsaba
Copy link
Copy Markdown

awsaba commented Jul 7, 2024

@J1mBob FYI I submitted #688 a few a weeks ago to add this and it is passing the tests if you want something to compare it to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants