Add new check for struct contains also @derive Jason.Encoder#12
Open
silviurosu wants to merge 5 commits intoxtian:masterfrom
Open
Add new check for struct contains also @derive Jason.Encoder#12silviurosu wants to merge 5 commits intoxtian:masterfrom
silviurosu wants to merge 5 commits intoxtian:masterfrom
Conversation
Owner
|
@silviurosu Can you change this so that the derive checked is set via a parameter? I don't want to add a check that is hard-coded for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added a custom check that every struct to have @derive Jason.Encoder
Many times a struct needs to be serialized either for bugtracking either for api responses. I often encountered this issue in my projects that somebody forgot to add this.
I find it useful.