-
Notifications
You must be signed in to change notification settings - Fork 1
Add Kiro terminal integration #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds conditional shell integration support for the Kiro terminal emulator, following the established pattern used for other development tools in the repository.
- Adds Kiro terminal integration that sources shell-specific integration scripts when running in the Kiro terminal
- Uses the existing
exists,shell_name, andsource_if_readableutility functions - Follows the same structure as direnv integration (lines 127-134)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if [ -n "$shell" ]; then | ||
| kiro_integration_path="$(kiro --locate-shell-integration-path "$shell" 2>/dev/null)" | ||
| if [ -n "$kiro_integration_path" ]; then | ||
| source_if_readable "$kiro_integration_path" | ||
| fi | ||
| unset kiro_integration_path | ||
| fi |
Copilot
AI
Nov 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The conditional check for shell_name on line 147 is unnecessary. Unlike the zoxide and mise integrations (lines 196-215) that verify shell_name exists as a function with exists shell_name, the direnv integration (lines 128-134) directly uses shell_name without this check. Since shell_name is defined in path_functions which is sourced before common_env, and returns an empty string for unsupported shells, the inner check is redundant. If the empty string is a concern, it would be caught by the subsequent validation on line 149. Consider simplifying to match the direnv pattern or add the exists shell_name check in the outer condition to match zoxide/mise.
| if [ -n "$shell" ]; then | |
| kiro_integration_path="$(kiro --locate-shell-integration-path "$shell" 2>/dev/null)" | |
| if [ -n "$kiro_integration_path" ]; then | |
| source_if_readable "$kiro_integration_path" | |
| fi | |
| unset kiro_integration_path | |
| fi | |
| kiro_integration_path="$(kiro --locate-shell-integration-path "$shell" 2>/dev/null)" | |
| if [ -n "$kiro_integration_path" ]; then | |
| source_if_readable "$kiro_integration_path" | |
| fi | |
| unset kiro_integration_path |
|
duplicated? #52 |
No description provided.