[IF-FINDING-007] Reviewed: Minor observations and improvements related to the Cosmos SDK v0.50 Upgrade#69
Merged
AdriaCarrera merged 1 commit intomainfrom Mar 18, 2025
Conversation
GuillemGarciaDev
approved these changes
Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[IF-FINDING-007] Minor observations and improvements related to the Cosmos SDK v0.50 Upgrade
Description
GetTxCmd() *cobra.Commandand GetQueryCmd() *cobra.Command is no longer required. The module manager detects when module commands are defined. If AutoCLI is enabled, EnhanceRootCommand() will add the auto-generated commands to the root command, unless a custom module command is defined and register that one instead.Problem scenarios
No issues, only following the upgrade guide.
Recommendation
As listed in the Description section.
Applied changes
GetTxCmdfrom cli