[IF-FINDING-005] Messages MsgDelegate and MsgCancelUnbondingDelegation should be disabled#63
Merged
AdriaCarrera merged 9 commits intomainfrom Mar 18, 2025
Merged
Conversation
…tion should be disabled
# Conflicts: # x/poa/keeper/hooks_test.go
GuillemGarciaDev
approved these changes
Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[IF-FINDING-005] Messages MsgDelegate and MsgCancelUnbondingDelegation should be disabled
Description
Since BondDenom tokens can only be minted and burned during validator creation (these tokens are immediately staked and bonded) and removal by an authority and both undelegate and redelegate messages are disabled, there are no free tokens available for delegation, nor any possibility of canceling unbonding delegation. This means the messages MsgDelegate and MsgCancelUnbondingDelegation are unnecessary and can be removed, simplifying the codebase.
Problem scenarios
No problem scenarios, just code clarity.
Recommendation
Explicitly disable MsgDelegate and MsgCancelUnbondingDelegation messages. If delegations are completely disabled, there is no need for BeforeDelegationHook implementation.
In order for authz-ed MsgDelegate and MsgCancelUnbondingDelegation messages to be disabled - add the messages among AuthzDisabledMsgTypes (code ref) in HandlerOptions.
Applied changes
Added
MsgDelegateandMsgCancelUnbondingDelegationin ante handler and authz disabled msgs