[IF-FINDING-001] Invariant checks through crisis module may go unnoticed

app/app.go

@@ -459,7 +459,6 @@ func New(
 		app.MsgServiceRouter(),
 		app.BankKeeper,
 		app.StakingKeeper,
-		app.SlashingKeeper,
 		authtypes.NewModuleAddress(govtypes.ModuleName).String(),
 	)
 

x/poa/keeper/common_test.go

@@ -54,13 +54,6 @@ func getBankKeeperMock(t *testing.T, ctx sdk.Context, setExpectations func(ctx s
 	return bankKeeper
 }
 
-func getSlashingKeeperMock(t *testing.T, ctx sdk.Context, setExpectations func(ctx sdk.Context, slashingKeeper *testutil.MockSlashingKeeper)) *testutil.MockSlashingKeeper {
-	ctrl := gomock.NewController(t)
-	slashingKeeper := testutil.NewMockSlashingKeeper(ctrl)
-	setExpectations(ctx, slashingKeeper)
-	return slashingKeeper
-}
-
 func getCtxMock(t *testing.T, key *storetypes.KVStoreKey, tsKey *storetypes.TransientStoreKey) sdk.Context {
 	setupSdkConfig()
 
@@ -69,7 +62,7 @@ func getCtxMock(t *testing.T, key *storetypes.KVStoreKey, tsKey *storetypes.Tran
 	return ctx
 }
 
-func getMockedPoAKeeper(t *testing.T, key *storetypes.KVStoreKey, tsKey *storetypes.TransientStoreKey, ctx sdk.Context, stakingKeeper *testutil.MockStakingKeeper, bankKeeper *testutil.MockBankKeeper, slashingKeeper *testutil.MockSlashingKeeper) *Keeper {
+func getMockedPoAKeeper(t *testing.T, key *storetypes.KVStoreKey, tsKey *storetypes.TransientStoreKey, ctx sdk.Context, stakingKeeper *testutil.MockStakingKeeper, bankKeeper *testutil.MockBankKeeper) *Keeper {
 	encCfg := moduletestutil.MakeTestEncodingConfig()
 
 	types.RegisterInterfaces(encCfg.InterfaceRegistry)
@@ -89,7 +82,6 @@ func getMockedPoAKeeper(t *testing.T, key *storetypes.KVStoreKey, tsKey *storety
 		msr,
 		bankKeeper,
 		stakingKeeper,
-		slashingKeeper,
 		"ethm1wunfhl05vc8r8xxnnp8gt62wa54r6y52pg03zq",
 	)
 	poaKeeper.SetParams(ctx, types.DefaultParams())
@@ -99,14 +91,13 @@ func getMockedPoAKeeper(t *testing.T, key *storetypes.KVStoreKey, tsKey *storety
 	return poaKeeper
 }
 
-func setupPoaKeeper(t *testing.T, setStakingExpectations func(ctx sdk.Context, stakingKeeper *testutil.MockStakingKeeper), setBankExpectations func(ctx sdk.Context, bankKeeper *testutil.MockBankKeeper), setSlashingExpectations func(ctx sdk.Context, slashingKeeper *testutil.MockSlashingKeeper)) (*Keeper, sdk.Context) {
+func setupPoaKeeper(t *testing.T, setStakingExpectations func(ctx sdk.Context, stakingKeeper *testutil.MockStakingKeeper), setBankExpectations func(ctx sdk.Context, bankKeeper *testutil.MockBankKeeper)) (*Keeper, sdk.Context) {
 	key := storetypes.NewKVStoreKey(types.StoreKey)
 	tsKey := storetypes.NewTransientStoreKey("test")
 
 	ctx := getCtxMock(t, key, tsKey)
 	stakingKeeper := getStakingKeeperMock(t, ctx, setStakingExpectations)
 	bankKeeper := getBankKeeperMock(t, ctx, setBankExpectations)
-	slashingKeeper := getSlashingKeeperMock(t, ctx, setSlashingExpectations)
 
-	return getMockedPoAKeeper(t, key, tsKey, ctx, stakingKeeper, bankKeeper, slashingKeeper), ctx
+	return getMockedPoAKeeper(t, key, tsKey, ctx, stakingKeeper, bankKeeper), ctx
 }

x/poa/keeper/hooks_test.go

@@ -15,7 +15,6 @@ func TestPoA_Hooks(t *testing.T) {
 		t,
 		func(_ sdk.Context, _ *testutil.MockStakingKeeper) {},
 		func(_ sdk.Context, _ *testutil.MockBankKeeper) {},
-		func(_ sdk.Context, _ *testutil.MockSlashingKeeper) {},
 	)
 
 	hooks := keeper.Hooks()

x/poa/keeper/keeper.go

@@ -28,7 +28,6 @@ type (
 		router     *baseapp.MsgServiceRouter // Msg server router
 		bk         types.BankKeeper
 		sk         types.StakingKeeper
-		ck         types.SlashingKeeper
 	}
 )
 
@@ -38,7 +37,6 @@ func NewKeeper(
 	router *baseapp.MsgServiceRouter,
 	bk types.BankKeeper,
 	sk types.StakingKeeper,
-	ck types.SlashingKeeper,
 	authority string,
 ) *Keeper {
 	// set KeyTable if it has not already been set
@@ -58,7 +56,6 @@ func NewKeeper(
 		router:     router,
 		bk:         bk,
 		sk:         sk,
-		ck:         ck,
 	}
 }
 

x/poa/keeper/keeper_test.go

@@ -44,9 +44,7 @@ func poaKeeperTestSetup(t *testing.T) (*Keeper, sdk.Context) {
 		bankKeeper.EXPECT().SendCoinsFromAccountToModule(ctx, gomock.Any(), gomock.Any(), gomock.Any()).Return(nil).AnyTimes()
 	}
 
-	slashingExpectations := func(_ sdk.Context, _ *testutil.MockSlashingKeeper) {}
-
-	return setupPoaKeeper(t, stakingExpectations, bankExpectations, slashingExpectations)
+	return setupPoaKeeper(t, stakingExpectations, bankExpectations)
 }
 
 // Define here Keeper methods to be unit tested

x/poa/module.go

@@ -127,9 +127,7 @@ func (am AppModule) RegisterServices(cfg module.Configurator) {
 }
 
 // RegisterInvariants registers the invariants of the module. If an invariant deviates from its predicted value, the InvariantRegistry triggers appropriate logic (most often the chain will be halted)
-func (am AppModule) RegisterInvariants(ir sdk.InvariantRegistry) {
-	keeper.RegisterInvariants(ir, am.keeper)
-}
+func (am AppModule) RegisterInvariants(_ sdk.InvariantRegistry) {}
 
 // InitGenesis performs the module's genesis initialization. It returns no validator updates.
 func (am AppModule) InitGenesis(ctx sdk.Context, cdc codec.JSONCodec, gs json.RawMessage) {