Conversation
banasa44
left a comment
banasa44
left a comment
There was a problem hiding this comment.
modules/ibc could be refactored, structure is currently highly packed. Suggestion:
/corewith interfaces, errors and constants/parsers/utilsmultiple utility functions from modules/ibc/services(/providers? not sure about this one, maybe add more paths) for business logic orchestration, clients and signers. Or/clientsand leavesigner.tsat top level.
| position += length; | ||
| } else { | ||
| // For other wire types, try to skip safely | ||
| console.warn(`Unknown wire type ${wireType} for field ${fieldNumber}, skipping`); |
There was a problem hiding this comment.
could define a ParserError/IBCParserError error class
| position += length; | ||
| } else { | ||
| // For other wire types, just skip one byte to avoid infinite loop | ||
| console.warn(`Unknown wire type ${wireType} for field ${fieldNumber} in BaseAccount`); |
There was a problem hiding this comment.
could define a ParserError/IBCParserError error class
| // For all other account types or if EthAccount parsing failed, use standard parsing | ||
| return accountFromAny(input); | ||
| } catch (error) { | ||
| console.error("Failed to parse account with ethermintAccountParser:", error); |
There was a problem hiding this comment.
could define a ParserError/IBCParserError error class
| // If EthAccount parsing fails, try fallback to standard parsing | ||
| return accountFromAny(input); | ||
| } catch (error) { | ||
| console.error("Failed to parse account:", error); |
There was a problem hiding this comment.
could define a ParserError/IBCParserError error class
| // Use the custom account parser | ||
| return ethermintAccountParser(accountAny); | ||
| } catch (error) { | ||
| console.error("Failed to get account:", error); |
There was a problem hiding this comment.
could define a ParserError/IBCParserError error class / use ProviderError
There was a problem hiding this comment.
create separate files for different utilities responsibilities (time, packet and chain)
There was a problem hiding this comment.
variant functions could be moved into a utils folder
There was a problem hiding this comment.
should we move this file into packages/shared?
There was a problem hiding this comment.
this file could also go to ''packages/shared/cosmos`
|
|
||
| async getAccounts(): Promise<readonly AccountData[]> { | ||
| const accountsWithPrivkeys = await this.getAccountsWithPrivkeys(); | ||
| return accountsWithPrivkeys.map(({ algo, pubkey, address }) => ({ |
There was a problem hiding this comment.
don't forget to complete
| import { SignDoc } from "cosmjs-types/cosmos/tx/v1beta1/tx"; | ||
| import { encodeSecp256k1Signature } from "./secp256k1"; | ||
|
|
||
| interface AccountDataWithPrivkey extends AccountData { |
# Conflicts: # modules/cosmos/configs/mainnet.module.config.json # modules/cosmos/configs/testnet.module.config.json # modules/cosmos/module.config.json # modules/cosmos/package.json # pnpm-lock.yaml
- Updated RPC URLs to use secure HTTPS endpoints across all environments. - Added IBC module and configuration for chain interoperability. - Revised EVM configurations with proper `evmDenom`, active precompiles, and enhanced fee market parameters. - Introduced Cosmos SDK v0.33.1 dependencies for compatibility improvements. - Included devnet configurations and adjusted test cases for mainnet, testnet, and devnet execution. - Made adjustments in `pnpm-lock.yaml` for upgraded dependencies and package resolution.
3 participants
[TA-5032]: ibc testsuite
Changes 🛠️
modules/cosmos
ibctransfer testsuite between IBC chainsNotes
EIP712signatures are not supported in@cosmjs. Need to implement it custom.