fix: Solidity tests and Proto#6
Open
JordiParraCrespo wants to merge 1 commit intorelease/v0.6.x-xrplevm.xfrom
Open
fix: Solidity tests and Proto#6JordiParraCrespo wants to merge 1 commit intorelease/v0.6.x-xrplevm.xfrom
JordiParraCrespo wants to merge 1 commit intorelease/v0.6.x-xrplevm.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a new protobuf definition for Ethereum-compatible secp256k1 cryptographic keys and improves clarity in the
MintingEnabledfunction of the ERC20 keeper by making the use of a placeholder coin more explicit.New cryptography protobuf definitions:
proto/cosmos/evm/crypto/v1/ethsecp256k1/keys.protodefiningPubKeyandPrivKeymessages for Ethereum secp256k1 keys, including documentation and package options.Code clarity improvements:
MintingEnabledinx/erc20/keeper/mint.goto construct a placeholdersdk.CoinwithAmount=1for denom checks, clarifying intent and usage.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
mainbranch