Add support for legacy Ethermint tx decoding#4
Merged
AdriaCarrera merged 2 commits intorelease/v0.6.x-xrplevm.xfrom Mar 5, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds backward compatibility in x/vm/types for decoding sdk.TxMsgData message responses that use the legacy Ethermint Any.TypeUrl for MsgEthereumTxResponse, with unit tests to validate the legacy path.
Changes:
- Added a legacy Ethermint
TypeUrlconstant and updatedDecodeTxResponsesto accept both current and legacy type URLs. - Added a unit test case that builds a tx response using the legacy Ethermint type URL and asserts successful decoding.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| x/vm/types/utils.go | Accepts legacy Ethermint Any.TypeUrl when decoding MsgEthereumTxResponse responses. |
| x/vm/types/utils_test.go | Adds coverage ensuring decoding succeeds for legacy Ethermint type URL responses. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AdriaCarrera
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds backward compatibility for decoding transaction responses that use a legacy Ethermint type URL. The main changes introduce support for the legacy type URL in the decoding logic and add corresponding unit tests to ensure this case is handled correctly.
Backward compatibility for legacy Ethermint type URL:
legacyMsgEthereumTxResponseTypeURLinutils.goto represent the legacy Ethermint type URL.DecodeTxResponsesfunction to recognize and decode both the current and legacy Ethermint type URLs when unmarshaling transaction responses.Testing enhancements:
utils_test.goto generate and validate a transaction response using the legacy Ethermint type URL. [1] [2]