fix: improve MediaSource and ManagedMediaSource detection method#252
Open
renoanzhou wants to merge 1 commit intoxqq:masterfrom
Open
fix: improve MediaSource and ManagedMediaSource detection method#252renoanzhou wants to merge 1 commit intoxqq:masterfrom
renoanzhou wants to merge 1 commit intoxqq:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The current code uses the
inoperator to detect ifMediaSourceandManagedMediaSourceexist. This approach has a potential issue: if someone setswindow.MediaSource = undefined, using theinoperator would still returntruebecause the property exists, even though its value isundefined.Solution
Change the detection method from using the
inoperator totypeof ... === 'function'checks to ensure:Changes
Context
This is particularly important when third-party players use patterns like:
which could create problems with the previous detection method if one of the values is undefined.
Testing
Verified this change works correctly in all supported browser environments and properly handles cases where MediaSource constructor is set to undefined.