Skip to content

When creating a process, set the FD_CLOEXEC flag on the master PTY #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
romainreignier wants to merge 1 commit into
base: master
Choose a base branch
from
Open

When creating a process, set the FD_CLOEXEC flag on the master PTY #193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions rosmon_core/src/monitor/node_monitor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,6 +717,10 @@ std::pair<int,int> NodeMonitor::createPTY()
if(openpty(&master, &slave, nullptr, nullptr, nullptr) == -1)
throw error("Could not open pseudo terminal for child process: {}", strerror(errno));

// Mark master as close-on-exec so it is not inherited by child processes
if(fcntl(master, F_SETFD, FD_CLOEXEC) == -1)
throw error("Could not set close-on-exec flag for PTY master: {}", strerror(errno));

// On Linux, a new unix98 pty is initialized with the output flag ONLCR set,
// which converts \n to \r\n
// Disable this bahavior by clearing the flag
Expand Down