core: add an argument to keep colors in no ui mode#186
Open
romainreignier wants to merge 1 commit intoxqms:masterfrom
Open
core: add an argument to keep colors in no ui mode#186romainreignier wants to merge 1 commit intoxqms:masterfrom
romainreignier wants to merge 1 commit intoxqms:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following my #185 (comment), here is a proposition about adding a mode to disable UI but keep the colors in the logs (or more precisely, adding colors based on the severity).
As explained in the issue, I have chosen to not detect if run in a TTY to enable colors automatically because in my use case, rosmon is started as a sub-process, hence not directly in a TTY.
I am not sure about the name of the argument and its short version, feel free to propose other names.
I am not a big fan of adding yet another global variable in main.cpp but I kept the same solution than when I have added the flush to stdout flag.