Skip to content

Event logging enabling using Script define#2

Merged
xprees merged 21 commits intomasterfrom
event-logging
Jun 8, 2025
Merged

Event logging enabling using Script define#2
xprees merged 21 commits intomasterfrom
event-logging

Conversation

@xprees
Copy link
Owner

@xprees xprees commented Jun 8, 2025

This PR enables package to be used using single branch instead of 2 separate feature branches. Additional Event-logging features are enabled using scripting symbol define from cz.xprees.event-logging package.

@xprees xprees requested a review from Copilot June 8, 2025 22:13
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables event logging via script defines by adding new icon metadata assets, cleaning up legacy editor scripts, and setting up npm packaging and CI workflows.

  • Added .meta files for event icon assets
  • Removed custom editor scripts for GameObjectListener and VoidEventListener
  • Introduced .npmignore and GitHub Actions workflow for npm publishing

Reviewed Changes

Copilot reviewed 75 out of 75 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Editor/Resources/*.svg.meta Added metadata for new event icon assets
Editor/GameObjectListenerEditor.cs Removed legacy editor script for GameObject listeners
Editor/Core/VoidEventListenerEditor.cs Removed legacy editor script for void event listeners
Editor/Core/EventChannelBaseEditor.cs Added empty base editor class for event channels
.npmignore New ignore patterns for npm packaging
.github/workflows/deploy.yml CI workflow for publishing to npm registry
Comments suppressed due to low confidence (5)

.github/workflows/deploy.yml:6

  • If the repository's default branch is main, consider adding it here or renaming master to main to ensure the workflow triggers correctly.
-      - master

Editor/GameObjectListenerEditor.cs:1

  • The removal of GameObjectListenerEditor will disable the invoke-event button for GameObject listeners; please confirm this is intended and update any relevant documentation or tests.
-using UnityEngine;

Editor/Core/VoidEventListenerEditor.cs:1

  • The removal of VoidEventListenerEditor removes the UI to invoke void events in the inspector; ensure this change is intentional and reflect it in the docs.
-using UnityEditor;

.npmignore:2

  • Removing .npmignore from its own ignore list so the file can be included in published packages.
.npmignore

Editor/Core/EventChannelBaseEditor.cs:6

  • [nitpick] This editor class is empty. Consider adding functionality or removing the file until you have editor-specific logic to implement.
[CustomEditor(typeof(EventChannelBaseSO<>), true)]

@xprees xprees merged commit 16a3b12 into master Jun 8, 2025
1 check passed
@xprees xprees deleted the event-logging branch June 8, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant