Conversation
…are distributed through other registries
There was a problem hiding this comment.
Pull Request Overview
This PR enables event logging via script defines by adding new icon metadata assets, cleaning up legacy editor scripts, and setting up npm packaging and CI workflows.
- Added
.metafiles for event icon assets - Removed custom editor scripts for
GameObjectListenerandVoidEventListener - Introduced
.npmignoreand GitHub Actions workflow for npm publishing
Reviewed Changes
Copilot reviewed 75 out of 75 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Editor/Resources/*.svg.meta | Added metadata for new event icon assets |
| Editor/GameObjectListenerEditor.cs | Removed legacy editor script for GameObject listeners |
| Editor/Core/VoidEventListenerEditor.cs | Removed legacy editor script for void event listeners |
| Editor/Core/EventChannelBaseEditor.cs | Added empty base editor class for event channels |
| .npmignore | New ignore patterns for npm packaging |
| .github/workflows/deploy.yml | CI workflow for publishing to npm registry |
Comments suppressed due to low confidence (5)
.github/workflows/deploy.yml:6
- If the repository's default branch is
main, consider adding it here or renamingmastertomainto ensure the workflow triggers correctly.
- - master
Editor/GameObjectListenerEditor.cs:1
- The removal of
GameObjectListenerEditorwill disable the invoke-event button for GameObject listeners; please confirm this is intended and update any relevant documentation or tests.
-using UnityEngine;
Editor/Core/VoidEventListenerEditor.cs:1
- The removal of
VoidEventListenerEditorremoves the UI to invoke void events in the inspector; ensure this change is intentional and reflect it in the docs.
-using UnityEditor;
.npmignore:2
- Removing
.npmignorefrom its own ignore list so the file can be included in published packages.
.npmignore
Editor/Core/EventChannelBaseEditor.cs:6
- [nitpick] This editor class is empty. Consider adding functionality or removing the file until you have editor-specific logic to implement.
[CustomEditor(typeof(EventChannelBaseSO<>), true)]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables package to be used using single branch instead of 2 separate feature branches. Additional Event-logging features are enabled using scripting symbol define from
cz.xprees.event-loggingpackage.