Open
Conversation
This reverts commit b27e3cc.
Mihajela
reviewed
Jul 16, 2021
| # smtp-client | ||
|
|
||
| > Simple, promisified, protocol-based SMTP client for Node.js. | ||
| > Simple promised, protocol-based SMTP client for Node.js. |
There was a problem hiding this comment.
Promisify is a method that defines in utilities module of Node. js the standard library, so "promisified" is correct.
Mihajela
reviewed
Jul 16, 2021
| > Simple promised, protocol-based SMTP client for Node.js. | ||
|
|
||
| This is an open source [npm](http://npmjs.com) package from [Node.js](http://nodejs.org). The source code is available on [GitHub](https://github.com/xpepermint/smtp-client) where you can also find our [issue tracker](https://github.com/xpepermint/smtp-client/issues). | ||
| This is an open-source [npm](http://npmjs.com) package from [Node.js](http://nodejs.org). The source code is available on [GitHub](https://github.com/xpepermint/smtp-client) where you can also find our [issue tracker](https://github.com/xpepermint/smtp-client/issues). |
There was a problem hiding this comment.
Open-source in this case is used as an adjective, and the correct spelling is in fact "open-source", as suggested.
Mihajela
reviewed
Jul 16, 2021
| **SMTPClient.prototype.connect({timeout})**:Promise; | ||
|
|
||
| > Connects to the SMTP server and starts socket I/O activity. | ||
| > Connects to the SMTP server and starts to socket I/O activity. |
There was a problem hiding this comment.
A socket is one endpoint of a two-way communication link between two programs running on the network.
The "socket I/0 activity" is correct.
Mihajela
reviewed
Jul 16, 2021
| **SMTPClient.prototype.data(source, {sourceSize, timeout})**:Promise; | ||
|
|
||
| > Sends the DATA command to the server which uploads the `source` of an email and finalize the process with the `.` (automatically appended to the source). | ||
| > Sends the DATA command to the server which uploads the `source` of an email and finalizes the process with the `.` (automatically appended to the source). |
There was a problem hiding this comment.
Finalize can in this instance be interpreted as command, therefore it is correct.
Mihajela
approved these changes
Jul 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed Typos