Skip to content

refactor: remove too simple converters #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lexdene merged 1 commit into from
Nov 22, 2025
Merged

refactor: remove too simple converters #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions drow/converter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
from decimal import Decimal
from typing import TypeVar
from collections.abc import Callable

Expand All @@ -8,11 +7,3 @@

def no_op(value: T) -> T:
return value


def convert_to_float(value: str) -> float:
return float(value)


def convert_to_decimal(value: str) -> Decimal:
return Decimal(value)
3 changes: 1 addition & 2 deletions tests/test_converter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
from drow.annotation import SuccessResponse, VectorData
from drow.model import InstantVector
from drow.parser import make_parser
from drow.converter import convert_to_decimal


class TestConverter(TestCase):
Expand All @@ -23,7 +22,7 @@ def test_convert_to_decimal(self) -> None:
],
},
}
parser = make_parser(convert_to_decimal)
parser = make_parser(Decimal)
parsed = parser.parse_query_response(resp)
assert isinstance(parsed, InstantVector)
value = parsed.series[0].value.value
Expand Down