Optimize: Skip module resolution if Puppetfile matches upstream#243
Open
Optimize: Skip module resolution if Puppetfile matches upstream#243
Conversation
When updating a control repository, if the Puppetfile in the upstream commit is identical to the one currently deployed, we can skip the expensive module resolution and extraction steps. This change: 1. Calculates SHA256 checksums of the deployed Puppetfile and the upstream Puppetfile content (retrieved via git show). 2. Signals a match via the needSyncEnvs map. 3. Checks this signal in resolvePuppetfile() to bypass module processing unless -force is used. This significantly speeds up deployments where only control repository content (like manifests or hiera data) changes but module dependencies remain static. Fixes #233
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When updating a control repository, if the Puppetfile in the upstream commit is identical to the one currently deployed, we can skip the expensive module resolution and extraction steps.
This change:
This significantly speeds up deployments where only control repository content (like manifests or hiera data) changes but module dependencies remain static.
Fixes #233