-
-
Notifications
You must be signed in to change notification settings - Fork 503
Add CJK-friendly Emphasis Extension #921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
MihaZupan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I'll try to take a closer look in a few days.
Do you have any feeling about whether the spec has willingness to adopt something like this out of the box?
Ideally something like this wouldn't even be an option, just the default behavior from the spec.
I think that "Out of the box" is a little bit too early for a while. It is not strictly compatible with CommonMark. It is a provisional spec and probably going to be revised once more (to peek the character two ahead to deal with some following variation sequences) |
| static bool IsNonEmojiGeneralUseVariantSelector(Rune r) => r.Value is >= 0xFE00 and <= 0xFE0E; | ||
| static bool IsIdeographicVariationSelector(Rune r) => r.Value is >= 0xE0100 and <= 0xE01EF; | ||
| static bool IsCjkAmbiousPunctuation(Rune main, Rune vs) => vs.Value is 0xFE01 && main.Value is 0x2018 or 0x2019 or 0x201C or 0x201D; | ||
| // As of Unicode 17 | ||
| static bool IsCjk(Rune r) => r.Value is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a link to where these constants are coming from
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
|
How can we refer to the polyfilled <ProjectReference Include="..\Markdig\Markdig.csproj">
<Aliases>global</Aliases>
</ProjectReference>forces us to add extra |
|
I'd ifdef the test to just NET |
|
I have no where should be |
|
Does something like this not work? #if NET
[Test]
[TestCase(...)]
public void TestCheckOpenCloseDelimiterCjkFriendly(...)
{
// ...
}
#endif |

Closes #890