Fix #17 #18
Open
Fix #17 #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use uncheckedAssign for object variant assignment
Contributor
Author
|
This change or a similar one is what I expect is needed, but it does not actually fix issue #17 until nim-lang/Nim#19266 is fixed. Also, there is some code duplication that I don't like, but I don't know a way to avoid it. |
Contributor
Author
|
I just want to update here that until nim-lang/Nim#19266 is fixed, this is untestable. I'm not 100% sure this is the entire fix, either. Perhaps a PR is premature or it could be left open until it can be verified. |
Owner
|
OK. I will keep an eye on the related PR in Nim |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use uncheckedAssign for object variant assignment