Skip to content

Fix IllegalStateException on getTransactionType() #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MikeEdgar merged 1 commit into from
Jan 27, 2026
Merged

Fix IllegalStateException on getTransactionType() #591

MikeEdgar merged 1 commit into from
Jan 27, 2026

Conversation

@ajacob
Copy link
Contributor

@ajacob ajacob commented Jan 27, 2026

Issue: #590

Problem

When calling StaEDIStreamReader.getTransactionType() on the second transaction of an EDI file on START_TRANSACTION event, we get an IllegalStateException

Solution

The purpose of this PR is to fix StaEDIStreamReader to make sure the lexer parse enough data to allow
retrieval of transaction type information

@ajacob
Fix IllegalStateException on getTransactionType()
c03263b 
**Problem**

When calling `StaEDIStreamReader.getTransactionType()` on
the second transaction of an EDI file on `START_TRANSACTION`
event, we get an `IllegalStateException`

**Solution**

The purpose of this PR is to fix `StaEDIStreamReader`
to make sure the lexer parse enough data to allow
retrieval of transaction type information
@MikeEdgar MikeEdgar added this to the v1.26.1 milestone Jan 27, 2026
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 27, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)
2 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@MikeEdgar MikeEdgar linked an issue Jan 27, 2026 that may be closed by this pull request
IllegalStateException when trying to get the second transaction type #590
Closed
MikeEdgar
MikeEdgar approved these changes Jan 27, 2026
View reviewed changes
Copy link
Member

@MikeEdgar MikeEdgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the issue and also for digging in and providing a fix! Don't worry about the Sonar issues, this looks good to me. I assume you'd like a release with the fix, so that will be coming shortly.

@MikeEdgar MikeEdgar merged commit 6559cb5 into xlate:master Jan 27, 2026
12 of 13 checks passed
@ajacob
Copy link
Contributor Author

ajacob commented Jan 27, 2026

Thank you for your almost instant reply @MikeEdgar!
I was testing the lib against a few simple EDI files and found this bug a bit randomly, a release could be fine for me to continue my tests but if you need other changes to go into the next release I can wait

@MikeEdgar
Copy link
Member

MikeEdgar commented Jan 27, 2026

I was testing the lib against a few simple EDI files and found this bug a bit randomly, a release could be fine for me to continue my tests but if you need other changes to go into the next release I can wait

It's simple enough to do a release and better to have it out.

@ajacob
Copy link
Contributor Author

ajacob commented Jan 27, 2026

Amazing, many thanks ! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MikeEdgar MikeEdgar MikeEdgar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.26.1

Development

Successfully merging this pull request may close these issues.

IllegalStateException when trying to get the second transaction type

2 participants

@ajacob @MikeEdgar