Skip to content

Conversation

@ah9142
Copy link
Contributor

@ah9142 ah9142 commented Jun 24, 2025

Hello.

If you are interested in accepting pull requests,
I implemented encode/decode support for the absolute SMS validity period format
as well as support for 2/3 enhanced SMS validity period formats.

I think the main thing you might want to check is the public Message struct.
New parameter fields AbsoluteVP and EnhancedVP for the new formats were added.
This way of adding them is simple and preserves backwards compatibility.
However, if you have any objections, then feel free to propose another way and let's see how to go forwards.

Arvo Heinonen added 4 commits June 24, 2025 11:53
This is to accommodate other TP-VP formats
that can take a variable amount of bytes.
Define ValidityPeriod as a type alias to RelativeValidityPeriod
for backward compatibility.
* Implement enhanced relative VP format support
* Implement enhanced "relative integer" VP format support
  where "relative integer" refers to the unnamed format
  denoted by 0b010 in 3GPP TS 23.040 9.2.3.12.3.
* Leave enhanced "relative semi-octet" format unsupported
  where "relative semi-octet" refers to the unnamed format
  denoted by 0b011 in 3GPP TS 23.040 9.2.3.12.3.
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 58.69565% with 38 lines in your changes missing coverage. Please review.

Project coverage is 34.76%. Comparing base (379970a) to head (8af6aa5).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
sms/validity_period.go 59.18% 16 Missing and 4 partials ⚠️
sms/sms.go 56.52% 8 Missing and 2 partials ⚠️
sms/sms_submit.go 63.15% 6 Missing and 1 partial ⚠️
at.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
- Coverage   36.13%   34.76%   -1.38%     
==========================================
  Files          18       21       +3     
  Lines        1605     1795     +190     
==========================================
+ Hits          580      624      +44     
- Misses        940     1080     +140     
- Partials       85       91       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ah9142
Copy link
Contributor Author

ah9142 commented Aug 18, 2025

@xlab a gentle reminder if you might take a look at this at some point.

@xlab xlab merged commit 25f37dd into xlab:master Nov 20, 2025
1 check passed
@xlab
Copy link
Owner

xlab commented Nov 20, 2025

@ah9142 apologies for the delay, I am actually happy to accept pull requests and new features there. Having more validity period options is a great feat, and thanks for keeping compatibility.

I don't have unfortunately hardware means to validate this, but if it works for you that's cool!

@ah9142
Copy link
Contributor Author

ah9142 commented Nov 20, 2025

No problem. I haven't been working on anything at related since, but good to have this merged to trunk though.

@ah9142 ah9142 deleted the support_more_tp_vpfs branch November 20, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants