Support for more SMS validity period formats #38
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
If you are interested in accepting pull requests,
I implemented encode/decode support for the absolute SMS validity period format
as well as support for 2/3 enhanced SMS validity period formats.
I think the main thing you might want to check is the public
Messagestruct.New parameter fields
AbsoluteVPandEnhancedVPfor the new formats were added.This way of adding them is simple and preserves backwards compatibility.
However, if you have any objections, then feel free to propose another way and let's see how to go forwards.