Refactored repo for easier modifications#16
Open
joreeves wants to merge 4 commits intoxjorma:mainfrom
Open
Conversation
fixed edge case where "content" was not found
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've refactored the repo to match the MOPs structure. This uses a package.json file to set environment variables. Notably this means the GOOGLE_MAPS_API_KEY can be set just once in the .json file. This also means that the external python scripts do not need to be set relative to the .hip file.
Some other benefits and ideas:
Feel free to merge this or rebuild it yourself as best makes sense. Thanks for making this available and great work!