libs/src/portable: fix build w/ gcc-14 #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building xinetd with gcc-14 in Buildroot raises the following error:
cvt.c: In function 'fcvt_r':
cvt.c:113:9: error: implicit declaration of function 'strx_nprint' [-Wimplicit-function-declaration]
113 | n = strx_nprint (buf, len, "%.*" FLOAT_FMT_FLAG "f", ndigit, value);
| ^~~~~~~~~~~
Including "str.h" header to fix the compiler error would add a
build-time dependency of libportable on libstr, creating a circular
dependency chhain:
libportable -> libstr -> libsio -> libportable
which results in GNU make dropping dependency edges and therefore not
fixing the original build error.
The commit keeps the existing library layering unchanged while restoring
successful builds with modern compilers.
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building xinetd with gcc-14 in Buildroot raises the following error:
cvt.c: In function 'fcvt_r':
cvt.c:113:9: error: implicit declaration of function 'strx_nprint' [-Wimplicit-function-declaration]
113 | n = strx_nprint (buf, len, "%.*" FLOAT_FMT_FLAG "f", ndigit, value);
| ^~~~~~~~~~~
Including "str.h" header to fix the compiler error would add a build-time dependency of libportable on libstr, creating a circular dependency chhain:
libportable -> libstr -> libsio -> libportable
which results in GNU make dropping dependency edges and therefore not fixing the original build error.
The commit keeps the existing library layering unchanged while restoring successful builds with modern compilers.